-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support for detecting choco installer without required hash #1810
Conversation
#1807 Signed-off-by: Alan Jowett <[email protected]>
Integration tests success for |
Codecov Report
@@ Coverage Diff @@
## main #1810 +/- ##
==========================================
+ Coverage 52.13% 55.28% +3.15%
==========================================
Files 77 77
Lines 6823 6857 +34
==========================================
+ Hits 3557 3791 +234
+ Misses 3023 2815 -208
- Partials 243 251 +8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG overall, thanks for the quick turnaround!
You just need to add a few more example in the files I provided in comment.
Thanks!
Signed-off-by: Alan Jowett <[email protected]>
Integration tests success for |
Integration tests success for |
Integration tests success for |
Stale pull request message |
Integration tests success for |
Merged! Congrats on the PR! |
Integration tests success for |
Signed-off-by: Alan Jowett [email protected]
What kind of change does this PR introduce?
Add support for detecting unpinned install using https://chocolatey.org/
What is the current behavior?
Scorecard ignores choco installs.
What is the new behavior (if this is a feature change)?**
Scorecard warns for choco installs with out required hash.
Which issue(s) this PR fixes
Fixes: #1807
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)