Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support for detecting choco installer without required hash #1810

Merged
merged 6 commits into from
Apr 25, 2022
Merged

✨ Support for detecting choco installer without required hash #1810

merged 6 commits into from
Apr 25, 2022

Conversation

Alan-Jowett
Copy link
Contributor

Signed-off-by: Alan Jowett [email protected]

What kind of change does this PR introduce?

Add support for detecting unpinned install using https://chocolatey.org/

What is the current behavior?

Scorecard ignores choco installs.

What is the new behavior (if this is a feature change)?**

Scorecard warns for choco installs with out required hash.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes: #1807

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Scorecard will issue a warning when installing packages using the Chocolatey installer but not pinning the install with a hash.

@Alan-Jowett Alan-Jowett temporarily deployed to integration-test April 2, 2022 16:21 Inactive
@github-actions
Copy link

github-actions bot commented Apr 2, 2022

Integration tests success for
[0ff239c]
(https://github.com/ossf/scorecard/actions/runs/2082599351)

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #1810 (b7ef74c) into main (44ad5f5) will increase coverage by 3.15%.
The diff coverage is 85.29%.

@@            Coverage Diff             @@
##             main    #1810      +/-   ##
==========================================
+ Coverage   52.13%   55.28%   +3.15%     
==========================================
  Files          77       77              
  Lines        6823     6857      +34     
==========================================
+ Hits         3557     3791     +234     
+ Misses       3023     2815     -208     
- Partials      243      251       +8     

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

checks/shell_download_validate.go Show resolved Hide resolved
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall, thanks for the quick turnaround!
You just need to add a few more example in the files I provided in comment.

Thanks!

checks/shell_download_validate.go Show resolved Hide resolved
Signed-off-by: Alan Jowett <[email protected]>
@Alan-Jowett Alan-Jowett temporarily deployed to integration-test April 6, 2022 23:03 Inactive
@Alan-Jowett Alan-Jowett temporarily deployed to integration-test April 6, 2022 23:04 Inactive
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Integration tests success for
[b4e304e]
(https://github.com/ossf/scorecard/actions/runs/2105572689)

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Integration tests success for
[dee6de5]
(https://github.com/ossf/scorecard/actions/runs/2105565636)

checks/shell_download_validate.go Outdated Show resolved Hide resolved
@Alan-Jowett Alan-Jowett temporarily deployed to integration-test April 14, 2022 14:49 Inactive
@github-actions
Copy link

Integration tests success for
[644ca64]
(https://github.com/ossf/scorecard/actions/runs/2167911938)

@github-actions
Copy link

Stale pull request message

@laurentsimon laurentsimon enabled auto-merge (squash) April 25, 2022 16:14
@laurentsimon laurentsimon temporarily deployed to integration-test April 25, 2022 16:14 Inactive
@github-actions
Copy link

Integration tests success for
[b7ef74c]
(https://github.com/ossf/scorecard/actions/runs/2221448992)

@laurentsimon laurentsimon merged commit fe6e091 into ossf:main Apr 25, 2022
@laurentsimon
Copy link
Contributor

Merged! Congrats on the PR!

@github-actions
Copy link

Integration tests success for
[9d28e1b]
(https://github.com/ossf/scorecard/actions/runs/2221446814)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ossf/scorecard should detect unpinned dependencies via chocolatey installer
3 participants