🌱 Use GITHUB_TOKEN for downloading protoc
#1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azeemshaikh38
requested review from
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
azeemshaikh38
changed the title
GITHUB_TOKEN for downloading protocGITHUB_TOKEN for downloading protoc
|
Integration tests success for |
Codecov Report
@@ Coverage Diff @@
## main #1797 +/- ##
=======================================
Coverage 54.71% 54.71%
=======================================
Files 67 67
Lines 6521 6521
=======================================
Hits 3568 3568
Misses 2713 2713
Partials 240 240 |
laurentsimon
approved these changes
Mar 29, 2022
Just trying it out. Want to ensure this wasn't the reason the failures were happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
An attempt at fixing failing protoc issues. Part of #1774
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)