Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Raw results for best practices badge #1795

Merged
merged 7 commits into from
Apr 25, 2022
Merged

✨ Raw results for best practices badge #1795

merged 7 commits into from
Apr 25, 2022

Conversation

laurentsimon
Copy link
Contributor

Raw results for best practices badge
No breaking changes

Raw results for best practices badge

@laurentsimon laurentsimon temporarily deployed to integration-test March 29, 2022 21:26 Inactive
@laurentsimon laurentsimon force-pushed the feat/rawcii branch 2 times, most recently from 05204b4 to 444eb43 Compare March 29, 2022 21:30
@github-actions
Copy link

Integration tests success for
[4b80c0f]
(https://github.com/ossf/scorecard/actions/runs/2061217195)

@github-actions
Copy link

Integration tests success for
[3aa15af]
(https://github.com/ossf/scorecard/actions/runs/2061217903)

@codecov
Copy link

codecov bot commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #1795 (0c830f7) into main (fe6e091) will decrease coverage by 0.49%.
The diff coverage is 8.19%.

@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
- Coverage   52.29%   51.80%   -0.50%     
==========================================
  Files          77       79       +2     
  Lines        6857     6899      +42     
==========================================
- Hits         3586     3574      -12     
- Misses       3026     3080      +54     
  Partials      245      245

azeemshaikh38
azeemshaikh38 reviewed Mar 30, 2022
View reviewed changes
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR compiling?

checks/cii_best_practices.go Outdated Show resolved Hide resolved
@laurentsimon
Copy link
Contributor Author

Is this PR compiling?

it used to before a rebase. Fixed now.

@laurentsimon laurentsimon reopened this Apr 1, 2022
@laurentsimon laurentsimon temporarily deployed to integration-test April 1, 2022 22:40 Inactive
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

Integration tests success for
[fb84bcf]
(https://github.com/ossf/scorecard/actions/runs/2080061196)

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

Integration tests success for
[99ea222]
(https://github.com/ossf/scorecard/actions/runs/2080067633)

@laurentsimon
Copy link
Contributor Author

@azeemshaikh38 PTAL

@laurentsimon laurentsimon temporarily deployed to integration-test April 11, 2022 22:48 Inactive
azeemshaikh38
azeemshaikh38 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@laurentsimon laurentsimon enabled auto-merge (squash) April 11, 2022 22:54
@github-actions
Copy link

Integration tests success for
[19edc33]
(https://github.com/ossf/scorecard/actions/runs/2151596809)

@laurentsimon laurentsimon temporarily deployed to integration-test April 14, 2022 01:21 Inactive
@github-actions
Copy link

Integration tests success for
[8317afc]
(https://github.com/ossf/scorecard/actions/runs/2164637207)

@github-actions
Copy link

Stale pull request message

@laurentsimon laurentsimon temporarily deployed to integration-test April 25, 2022 16:45 Inactive
@github-actions
Copy link

Integration tests success for
[0c830f7]
(https://github.com/ossf/scorecard/actions/runs/2221600936)

@laurentsimon laurentsimon merged commit ac88460 into ossf:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeemshaikh38 azeemshaikh38 azeemshaikh38 approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@naveensrinivasan naveensrinivasan Awaiting requested review from naveensrinivasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentsimon @azeemshaikh38