Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Make Vuln ID field lower case in raw results #1761

Merged
merged 7 commits into from
Mar 25, 2022
Merged

✨ Make Vuln ID field lower case in raw results #1761

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
675169d
case sensitive ID
laurentsimon Mar 21, 2022
7ca28b8
updates
laurentsimon Mar 21, 2022
8aafaf9
Merge branch 'main' into feat/rawfix
laurentsimon Mar 22, 2022
9d5cd4e
Merge branch 'main' into feat/rawfix
laurentsimon Mar 22, 2022
ea326c2
Merge branch 'main' into feat/rawfix
laurentsimon Mar 22, 2022
2168d66
Merge branch 'main' into feat/rawfix
laurentsimon Mar 22, 2022
9418913
Merge branch 'main' into feat/rawfix
laurentsimon Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cron/format/json.raw.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,12 @@
"items": {
"type": "object",
"properties": {
"ID": {
"id": {
"type": "string"
}
},
"required": [
"ID"
"id"
]
}
},
Expand Down
4 changes: 2 additions & 2 deletions pkg/json.raw.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,12 @@
"items": {
"type": "object",
"properties": {
"ID": {
"id": {
"type": "string"
}
},
"required": [
"ID"
"id"
]
}
},
Expand Down
14 changes: 7 additions & 7 deletions pkg/json_raw_results.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,13 @@ type jsonDefaultBranchCommit struct {
// TODO: check runs, etc.
}

type jsonDatabaseVulnerability struct {
// For OSV: OSV-2020-484
// For CVE: CVE-2022-23945
ID string `json:"id"`
// TODO: additional information
}

type jsonRawResults struct {
DatabaseVulnerabilities []jsonDatabaseVulnerability `json:"database-vulnerabilities"`
// List of binaries found in the repo.
Expand Down Expand Up @@ -151,13 +158,6 @@ func (r *jsonScorecardRawResult) addCodeReviewRawResults(cr *checker.CodeReviewD
return nil
}

type jsonDatabaseVulnerability struct {
// For OSV: OSV-2020-484
// For CVE: CVE-2022-23945
ID string
// TODO: additional information
}

//nolint:unparam
func (r *jsonScorecardRawResult) addVulnerbilitiesRawResults(vd *checker.VulnerabilitiesData) error {
r.Results.DatabaseVulnerabilities = []jsonDatabaseVulnerability{}
Expand Down