Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix schemas from https://github.com/ossf/scorecard/pull/1758 #1760

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

laurentsimon
Copy link
Contributor

Inadvertently forgot to include certain fields in the JSON schema for raw results.
Noo rbaking changes

Update JSON schema for raw results

@laurentsimon laurentsimon temporarily deployed to integration-test March 21, 2022 20:49 Inactive
@laurentsimon laurentsimon temporarily deployed to integration-test March 21, 2022 20:50 Inactive
@laurentsimon laurentsimon enabled auto-merge (squash) March 21, 2022 20:51
@laurentsimon laurentsimon temporarily deployed to integration-test March 21, 2022 20:53 Inactive
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed for this PR, but is there a way to automate the maintenance of this schema file? Can this be auto-generated based on the Golang struct that is used to generate this?

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #1760 (5c83edb) into main (ee623e5) will increase coverage by 3.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1760      +/-   ##
==========================================
+ Coverage   56.71%   59.79%   +3.07%     
==========================================
  Files          65       65              
  Lines        6377     6377              
==========================================
+ Hits         3617     3813     +196     
+ Misses       2519     2317     -202     
- Partials      241      247       +6     

@github-actions
Copy link

Integration tests success for
[bedcab6]
(https://github.com/ossf/scorecard/actions/runs/2018686767)

@github-actions
Copy link

Integration tests success for
[6043b2b]
(https://github.com/ossf/scorecard/actions/runs/2018682058)

@github-actions
Copy link

Integration tests success for
[5c83edb]
(https://github.com/ossf/scorecard/actions/runs/2018689419)

@laurentsimon laurentsimon merged commit 1094680 into ossf:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants