Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 .github: Audit CodeQL egress with harden-runner #1728

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

naveensrinivasan
Copy link
Member

What kind of change does this PR introduce?

Included hard-runner to restrict egress traffic.

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

NONE

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test March 13, 2022 15:47 Inactive
@naveensrinivasan
Copy link
Member Author

@ossf/scorecard-maintainers I would like to propose this change. Let me know if someone has a different opinion.

cc @varunsh-coder

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #1728 (9adb214) into main (c8af71c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1728   +/-   ##
=======================================
  Coverage   57.02%   57.02%           
=======================================
  Files          63       63           
  Lines        6192     6192           
=======================================
  Hits         3531     3531           
  Misses       2420     2420           
  Partials      241      241           

@naveensrinivasan
Copy link
Member Author

@github-actions
Copy link

Integration tests success for
[544e66f]
(https://github.com/ossf/scorecard/actions/runs/1976797558)

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test March 14, 2022 21:57 Inactive
@github-actions
Copy link

Integration tests success for
[a40b6e9]
(https://github.com/ossf/scorecard/actions/runs/1983360145)

@varunsh-coder
Copy link
Contributor

The license for hard-runner is https://github.com/step-security/harden-runner/blob/main/LICENSE

Thanks @naveensrinivasan for trying it out. Let me know if you need any help adding it. Note: the Action uses an agent, and the agent also has the same license.

https://github.com/step-security/agent/blob/main/LICENSE

I am trying to make harden-runner an OSSF project. So do share feedback from using this, as those improvement ideas can be used in the OSSF project, if/when that gets thru...Thanks!

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @justaugustus @laurentsimon for a second opinion.

@justaugustus justaugustus changed the title 🌱 Included hard-runner to restrict outbound egress 🌱 .github: Audit CodeQL egress with harden-runner Mar 15, 2022
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naveensrinivasan -- Tweaked the PR title, since we're auditing egress, not blocking yet

@justaugustus justaugustus enabled auto-merge (squash) March 15, 2022 16:09
Included hard-runner to restrict egress traffic.
@justaugustus justaugustus temporarily deployed to integration-test March 15, 2022 16:09 Inactive
@github-actions
Copy link

Integration tests success for
[9adb214]
(https://github.com/ossf/scorecard/actions/runs/1987850347)

@justaugustus justaugustus merged commit c8acf36 into main Mar 15, 2022
@justaugustus justaugustus deleted the naveen/hard-runner branch March 15, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants