-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Changed jsonScorecardResultV2 type Public #1682
Conversation
7dd12c0
to
fc7508d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1682 +/- ##
==========================================
+ Coverage 57.45% 60.58% +3.13%
==========================================
Files 58 58
Lines 5907 5907
==========================================
+ Hits 3394 3579 +185
+ Misses 2276 2085 -191
- Partials 237 243 +6 |
Integration tests success for |
fc7508d
to
59c4afc
Compare
Integration tests success for |
Integration tests success for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naveensrinivasan -- One nit about the nolint
!
Co-authored-by: Stephen Augustus (he/him) <[email protected]>
Integration tests success for |
Integration tests success for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixed the govet linter warning by including nolint.
@justaugustus Looks like that is required for fieldalingment. Can you please 👀 ? |
Integration tests success for |
Integration tests success for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justaugustus Looks like that is required for fieldalingment. Can you please 👀 ?
@naveensrinivasan -- Yep, I think moving the date
field(str) to the bottom would fix it, but that's non-blocking!
👍 |
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)