Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Changed jsonScorecardResultV2 type Public #1682

Merged
merged 6 commits into from
Feb 28, 2022

Conversation

naveensrinivasan
Copy link
Member

@naveensrinivasan naveensrinivasan commented Feb 26, 2022

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Made the jsonScorecardResultV2 to public to make it easier for the consumers of Scorecard.

@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #1682 (3d086ed) into main (4635570) will increase coverage by 3.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1682      +/-   ##
==========================================
+ Coverage   57.45%   60.58%   +3.13%     
==========================================
  Files          58       58              
  Lines        5907     5907              
==========================================
+ Hits         3394     3579     +185     
+ Misses       2276     2085     -191     
- Partials      237      243       +6     

@github-actions
Copy link

Integration tests success for
[fc7508d]
(https://github.com/ossf/scorecard/actions/runs/1904155295)

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test February 27, 2022 00:45 Inactive
@github-actions
Copy link

Integration tests success for
[59c4afc]
(https://github.com/ossf/scorecard/actions/runs/1904632235)

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test February 27, 2022 02:33 Inactive
@github-actions
Copy link

Integration tests success for
[182bbde]
(https://github.com/ossf/scorecard/actions/runs/1904861662)

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naveensrinivasan -- One nit about the nolint!

pkg/json.go Show resolved Hide resolved
Co-authored-by: Stephen Augustus (he/him) <[email protected]>
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test February 27, 2022 16:14 Inactive
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test February 27, 2022 16:16 Inactive
@github-actions
Copy link

Integration tests success for
[c89ecd8]
(https://github.com/ossf/scorecard/actions/runs/1906606325)

@github-actions
Copy link

Integration tests success for
[53019ad]
(https://github.com/ossf/scorecard/actions/runs/1906608227)

Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Fixed the govet linter warning by including  nolint.
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test February 28, 2022 20:02 Inactive
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test February 28, 2022 20:05 Inactive
@naveensrinivasan
Copy link
Member Author

@naveensrinivasan -- One nit about the nolint!

@justaugustus Looks like that is required for fieldalingment. Can you please 👀 ?

@naveensrinivasan naveensrinivasan enabled auto-merge (squash) February 28, 2022 20:06
@github-actions
Copy link

Integration tests success for
[f7f048e]
(https://github.com/ossf/scorecard/actions/runs/1912315464)

@github-actions
Copy link

Integration tests success for
[3d086ed]
(https://github.com/ossf/scorecard/actions/runs/1912323070)

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justaugustus Looks like that is required for fieldalingment. Can you please 👀 ?

@naveensrinivasan -- Yep, I think moving the date field(str) to the bottom would fix it, but that's non-blocking!

@naveensrinivasan naveensrinivasan merged commit ddb0fe3 into main Feb 28, 2022
@naveensrinivasan naveensrinivasan deleted the naveen/feat/changescope branch February 28, 2022 20:20
@naveensrinivasan
Copy link
Member Author

@justaugustus Looks like that is required for fieldalingment. Can you please 👀 ?

@naveensrinivasan -- Yep, I think moving the date field(str) to the bottom would fix it, but that's non-blocking!

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Public JSON Type
4 participants