📖 Refine copy for PR template and add a release-note code fence
#1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Augustus <[email protected]>
|
cc: @ossf/scorecard-maintainers |
Codecov Report
@@ Coverage Diff @@
## main #1678 +/- ##
==========================================
+ Coverage 58.50% 61.69% +3.18%
==========================================
Files 58 58
Lines 5801 5801
==========================================
+ Hits 3394 3579 +185
+ Misses 2170 1979 -191
- Partials 237 243 +6 |
|
Integration tests success for |
naveensrinivasan
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
See https://github.com/ossf/scorecard/blob/504f13441636dcc6273d45d9dc1e7ea1ef080ae2/.github/PULL_REQUEST_TEMPLATE.md.
What is the new behavior (if this is a feature change)?**
Adding a
release-notecode fence will allow us to start leverage the Kubernetesrelease-notestool: https://git.k8s.io/release/cmd/release-notes/README.mdSee comparison
https://github.com/ossf/scorecard/releases/tag/v4.1.0:
https://github.com/kubernetes/release/releases/tag/v0.13.0:
Which issue(s) this PR fixes
Partially addresses #1677.
Special notes for your reviewer
I've used the proposed PR template for this PR and added a fake release note that we can later test against.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)