Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Generalize CheckIfFileExists fn #1668

Merged
merged 1 commit into from
Feb 22, 2022
Merged

🌱 Generalize CheckIfFileExists fn #1668

merged 1 commit into from
Feb 22, 2022

Conversation

azeemshaikh38
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 commented Feb 22, 2022

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Removes all existing versions of CheckIfFileExists and replaces them with a more generalized version. Part of Feature: deprecate Pass/Fail model #1393

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 22, 2022 18:32 Inactive
@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) February 22, 2022 18:33
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions
Copy link

Integration tests success for
[c1141dc]
(https://github.com/ossf/scorecard/actions/runs/1883311449)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 22, 2022 18:43 Inactive
@github-actions
Copy link

Integration tests success for
[5e1c673]
(https://github.com/ossf/scorecard/actions/runs/1883357818)

@azeemshaikh38 azeemshaikh38 merged commit f616278 into main Feb 22, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/fileparser branch February 22, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants