✨ Token-Permissions, Allow contents: write permission only for jobs that are releasing
#1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ristomcgehee
requested review from
azeemshaikh38,
inferno-chromium,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1663 +/- ##
==========================================
+ Coverage 55.86% 61.69% +5.82%
==========================================
Files 72 58 -14
Lines 6508 5801 -707
==========================================
- Hits 3636 3579 -57
+ Misses 2618 1979 -639
+ Partials 254 243 -11 |
ristomcgehee
commented
Feb 19, 2022
|
Integration tests success for |
Allowing `contents: write` permission only for jobs that are releasing jobs, not just packaging jobs.
ristomcgehee
force-pushed
the
contents-releasing
branch
from
5967ad5 to
577a8fd
Compare
|
Integration tests success for |
| } | ||
|
|
||
| // matches returns true if the job matches the job matcher. | ||
| func (m *JobMatcher) matches(job *actionlint.Job) bool { |
There was a problem hiding this comment.
Similar comment , should this be a job *actionlint.Job pointer?
azeemshaikh38
approved these changes
Feb 21, 2022
checks/testdata/.github/workflows/github-workflow-permissions-contents-writes-release.yaml
Outdated
Show resolved
Hide resolved
|
Integration tests success for |
|
Integration tests success for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
If a GitHub workflow job has
contents: writepermission and it is a publishing job, it will not have its score reduced.Feature: differentiate between
packageandcontentspermission in Token-Permission #1254What is the new behavior (if this is a feature change)?
If a GitHub workflow job has
contents: writepermission and it is a publishing job, it will have its score reduced. If a GitHub workflow job hascontents: writepermission and it is a releasing job, it will not have its score reduced.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
I looked through all of
isPackagingWorkflowand determined the only ones that looked like they neededcontents: writeweregoreleaserandpython-semantic-release. I leftgoreleaserinisPackagingWorkflowso as not to alter the behavior of the Packaging check, even though that action does not need thepackages: writepermission.python-semantic-releaserequires bothpackages: writeandcontents: write.