📖 Adding missing documentation for Token-Permissions #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1656 +/- ##
==========================================
+ Coverage 58.50% 61.69% +3.18%
==========================================
Files 58 58
Lines 5801 5801
==========================================
+ Hits 3394 3579 +185
+ Misses 2170 1979 -191
- Partials 237 243 +6 |
|
Integration tests success for |
|
Integration tests success for |
|
Integration tests success for |
azeemshaikh38
requested review from
laurentsimon
and removed request for
olivekl
azeemshaikh38
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Looks good to me. Will also wait for @laurentsimon's approval.
laurentsimon
approved these changes
Feb 22, 2022
ristomcgehee
requested review from
inferno-chromium and
naveensrinivasan
as code owners
|
Integration tests success for |
|
Integration tests success for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update
What is the current behavior? (You can also link to an open issue here)
The Token-Permissions check documentation does not include documentation on when the score is reduced due to certain write permissions being present on a job.