✨ Miscellaneous refactors to ease downstream consumption

[justaugustus]

• Please check if the PR fulfills these requirements

• Tests for the changes have been added (for bug fixes / features)
• PR title follows the guidelines defined in https://github.com/ossf/scorecard/blob/main/CONTRIBUTING.md#pr-process

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

• checker: Add NewLogger constructor for DetailLogger impl
• checker: Add NewRunner constructor for Runner
• cmd: Move command flags and validation into an options package
• cmd: Move client accessors to githubrepo package
• cmd: Move policy and enabled checks to policy package
• cmd: Move results formatting to format package
• Fixup lint warnings

Signed-off-by: Stephen Augustus [email protected]

Tested against ossf/allstar#114.

cc: @jeffmendoza

• What is the current behavior? (You can also link to an open issue here)

• What is the new behavior (if this is a feature change)?

• Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

• Other information:

[github-actions]

Integration tests success for
[0e0ac01]
(https://github.com/ossf/scorecard/actions/runs/1850434912)

[codecov-commenter]

Codecov Report

Merging #1645 (b42de44) into main (7610519) will increase coverage by 2.08%.
The diff coverage is 1.73%.

@@            Coverage Diff             @@
##             main    #1645      +/-   ##
==========================================
+ Coverage   58.50%   60.58%   +2.08%     
==========================================
  Files          58       58              
  Lines        5801     5907     +106     
==========================================
+ Hits         3394     3579     +185     
+ Misses       2170     2085      -85     
- Partials      237      243       +6     

[github-actions]

Integration tests success for
[29f9cd8]
(https://github.com/ossf/scorecard/actions/runs/1850438705)

[github-actions]

Integration tests success for
[a14d103]
(https://github.com/ossf/scorecard/actions/runs/1850505498)

[github-actions]

Integration tests success for
[4e4795b]
(https://github.com/ossf/scorecard/actions/runs/1853410891)

[github-actions]

Integration tests success for
[fe71973]
(https://github.com/ossf/scorecard/actions/runs/1853547678)

[github-actions]

Integration tests success for
[aa712bc]
(https://github.com/ossf/scorecard/actions/runs/1853943335)

[github-actions]

Integration tests success for
[e00aaeb]
(https://github.com/ossf/scorecard/actions/runs/1854193192)

[github-actions]

Integration tests success for
[e3f9f95]
(https://github.com/ossf/scorecard/actions/runs/1854200579)

[github-actions]

Integration tests success for
[25bba32]
(https://github.com/ossf/scorecard/actions/runs/1895856470)

[naveensrinivasan]

Thanks! I am OK with this change.

[azeemshaikh38]

Thanks!

[github-actions]

Integration tests success for
[b42de44]
(https://github.com/ossf/scorecard/actions/runs/1904791959)