Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add tests for graphQL costs #1643

Merged
merged 1 commit into from
Feb 15, 2022
Merged

✨ Add tests for graphQL costs #1643

merged 1 commit into from
Feb 15, 2022

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Closes BUG: Fixer high GitHub API usage #1623

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) February 15, 2022 21:45
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 15, 2022 21:45 Inactive
@github-actions
Copy link

Integration tests success for
[efdbb40]
(https://github.com/ossf/scorecard/actions/runs/1849566808)

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #1643 (981f99d) into main (de5224b) will increase coverage by 2.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
+ Coverage   56.12%   58.97%   +2.84%     
==========================================
  Files          72       72              
  Lines        6493     6493              
==========================================
+ Hits         3644     3829     +185     
+ Misses       2604     2413     -191     
- Partials      245      251       +6     

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 15, 2022 22:33 Inactive
@github-actions
Copy link

Integration tests success for
[d91ca5a]
(https://github.com/ossf/scorecard/actions/runs/1849758650)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 15, 2022 22:42 Inactive
@github-actions
Copy link

Integration tests success for
[981f99d]
(https://github.com/ossf/scorecard/actions/runs/1849792775)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 15, 2022 23:21 Inactive
@github-actions
Copy link

Integration tests success for
[387e188]
(https://github.com/ossf/scorecard/actions/runs/1849934727)

@azeemshaikh38 azeemshaikh38 merged commit cda7a1b into main Feb 15, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/e2e branch February 15, 2022 23:38
@@ -261,7 +261,7 @@ test: $(test-targets)
unit-test: ## Runs unit test without e2e
# Run unit tests, ignoring e2e tests
# run the go tests and gen the file coverage-all used to do the integration with codecov
go test -race -covermode=atomic -coverprofile=unit-coverage.out `go list ./... | grep -v e2e`
SKIP_GINKGO=1 go test -race -covermode=atomic -coverprofile=unit-coverage.out `go list ./...`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason these e2e tests couldn't sit in the e2e dir?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@06kellyjac Nice suggestion, Thanks. Do you want to do a PR for the change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests added in this PR rely on some internal (non-exposed) fields. So, had to create the tests in the same package as it was testing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough, thanks for the details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Fixer high GitHub API usage
6 participants