Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add validation for commit-based APIs #1635

Merged
merged 2 commits into from
Feb 14, 2022
Merged

🌱 Add validation for commit-based APIs #1635

merged 2 commits into from
Feb 14, 2022

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Add validation to ensure APIs unsupported by commit-based Scorecard do not get called.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) February 14, 2022 17:50
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 14, 2022 17:50 Inactive
@github-actions
Copy link

Integration tests success for
[484e447]
(https://github.com/ossf/scorecard/actions/runs/1842613986)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 14, 2022 18:33 Inactive
@github-actions
Copy link

Integration tests success for
[056839e]
(https://github.com/ossf/scorecard/actions/runs/1842815194)

@codecov-commenter
Copy link

Codecov Report

Merging #1635 (056839e) into main (eb0730a) will decrease coverage by 0.21%.
The diff coverage is 2.40%.

@@            Coverage Diff             @@
##             main    #1635      +/-   ##
==========================================
- Coverage   55.64%   55.42%   -0.22%     
==========================================
  Files          72       72              
  Lines        6513     6542      +29     
==========================================
+ Hits         3624     3626       +2     
- Misses       2647     2674      +27     
  Partials      242      242              

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 14, 2022 21:58 Inactive
@github-actions
Copy link

Integration tests success for
[1ebb61f]
(https://github.com/ossf/scorecard/actions/runs/1843705806)

@azeemshaikh38 azeemshaikh38 merged commit f3332ce into main Feb 14, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/commit branch February 14, 2022 22:24
@azeemshaikh38 azeemshaikh38 linked an issue Feb 14, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit based scorecard
4 participants