Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Simplify DetailLogger #1628

Merged
merged 1 commit into from
Feb 11, 2022
Merged

⚠️ Simplify DetailLogger #1628

merged 1 commit into from
Feb 11, 2022

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Part of Feature: deprecate Pass/Fail model #1393

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) February 11, 2022 21:38
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 11, 2022 21:39 Inactive
@github-actions
Copy link

Integration tests success for
[97d0d3d]
(https://github.com/ossf/scorecard/actions/runs/1831646111)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 11, 2022 21:55 Inactive
@github-actions
Copy link

Integration tests success for
[6236840]
(https://github.com/ossf/scorecard/actions/runs/1831700953)

@azeemshaikh38 azeemshaikh38 changed the title 🌱 Simplify DetailLogger ⚠️ Simplify DetailLogger Feb 11, 2022
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 11, 2022 22:22 Inactive
@github-actions
Copy link

Integration tests success for
[737146b]
(https://github.com/ossf/scorecard/actions/runs/1831805989)

@codecov-commenter
Copy link

Codecov Report

Merging #1628 (737146b) into main (38be00c) will increase coverage by 0.29%.
The diff coverage is 83.90%.

@@            Coverage Diff             @@
##             main    #1628      +/-   ##
==========================================
+ Coverage   55.34%   55.64%   +0.29%     
==========================================
  Files          72       72              
  Lines        6441     6513      +72     
==========================================
+ Hits         3565     3624      +59     
- Misses       2634     2647      +13     
  Partials      242      242              

Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

checks/ci_tests.go Show resolved Hide resolved
@azeemshaikh38 azeemshaikh38 merged commit 2e3e505 into main Feb 11, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/logr branch February 11, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants