Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add support for commit-based lookup to GitHub APIs #1612

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Add support for non-HEAD commit lookup in GitHub RepoClient. This PR attempts to add the support while not changing the behavior. Once the e2e tests confirm that this does not break anything will follow-up with exposing this feature externally.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

@azeemshaikh38 azeemshaikh38 changed the base branch from azeems/check-tags to main February 7, 2022 20:57
@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) February 7, 2022 20:58
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 7, 2022 21:17 Inactive
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Integration tests success for
[384d59e]
(https://github.com/ossf/scorecard/actions/runs/1808898824)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 7, 2022 21:23 Inactive
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Integration tests success for
[f83c1fd]
(https://github.com/ossf/scorecard/actions/runs/1808927452)

@codecov-commenter
Copy link

Codecov Report

Merging #1612 (f83c1fd) into main (30fc06e) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1612      +/-   ##
==========================================
- Coverage   54.72%   54.60%   -0.13%     
==========================================
  Files          72       72              
  Lines        6257     6271      +14     
==========================================
  Hits         3424     3424              
- Misses       2612     2626      +14     
  Partials      221      221              

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 7, 2022 21:46 Inactive
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Integration tests success for
[2e3877f]
(https://github.com/ossf/scorecard/actions/runs/1809024005)

@azeemshaikh38 azeemshaikh38 merged commit eac2aec into main Feb 7, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/commit branch February 7, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants