Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Only run allowed checks in different modes #1579

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Replace file parsing logic for recognizing supported/unsupported checks.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 1, 2022 17:55 Inactive
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 1, 2022 17:57 Inactive
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Integration tests success for
[d46b0c6]
(https://github.com/ossf/scorecard/actions/runs/1779860555)

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Integration tests success for
[a4a50e7]
(https://github.com/ossf/scorecard/actions/runs/1779866753)

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) February 1, 2022 18:06
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

Merging #1579 (24fe581) into main (eac2aec) will increase coverage by 0.17%.
The diff coverage is 59.09%.

@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
+ Coverage   54.88%   55.05%   +0.17%     
==========================================
  Files          72       72              
  Lines        6271     6295      +24     
==========================================
+ Hits         3442     3466      +24     
  Misses       2604     2604              
  Partials      225      225              

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 3, 2022 15:59 Inactive
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Integration tests success for
[88d840a]
(https://github.com/ossf/scorecard/actions/runs/1790421347)

Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Added a question abt the reasoning behind moving the type from checks.yaml to the check's implementation

checks/binary_artifact.go Show resolved Hide resolved
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 6, 2022 16:41 Inactive
@github-actions
Copy link

github-actions bot commented Feb 6, 2022

Integration tests success for
[e0fbca2]
(https://github.com/ossf/scorecard/actions/runs/1802845102)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 7, 2022 17:28 Inactive
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Integration tests success for
[039b97c]
(https://github.com/ossf/scorecard/actions/runs/1807869831)

@azeemshaikh38 azeemshaikh38 force-pushed the azeems/check-tags branch 2 times, most recently from ef1a35d to c12f6ba Compare February 7, 2022 22:19
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 7, 2022 22:19 Inactive
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Integration tests success for
[c12f6ba]
(https://github.com/ossf/scorecard/actions/runs/1809159113)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 7, 2022 23:30 Inactive
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Integration tests success for
[24fe581]
(https://github.com/ossf/scorecard/actions/runs/1809415597)

@azeemshaikh38 azeemshaikh38 merged commit 1c95237 into main Feb 8, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/check-tags branch February 8, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants