-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Only run allowed checks in different modes #1579
Conversation
d46b0c6
to
a4a50e7
Compare
Integration tests success for |
Integration tests success for |
Codecov Report
@@ Coverage Diff @@
## main #1579 +/- ##
==========================================
+ Coverage 54.88% 55.05% +0.17%
==========================================
Files 72 72
Lines 6271 6295 +24
==========================================
+ Hits 3442 3466 +24
Misses 2604 2604
Partials 225 225 |
a4a50e7
to
626b3b5
Compare
626b3b5
to
88d840a
Compare
Integration tests success for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Added a question abt the reasoning behind moving the type from checks.yaml to the check's implementation
Integration tests success for |
e0fbca2
to
039b97c
Compare
Integration tests success for |
ef1a35d
to
c12f6ba
Compare
Integration tests success for |
c12f6ba
to
24fe581
Compare
Integration tests success for |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Replace file parsing logic for recognizing supported/unsupported checks.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.