Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Refactor some code #1567

Merged
merged 1 commit into from
Jan 31, 2022
Merged

🌱 Refactor some code #1567

merged 1 commit into from
Jan 31, 2022

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Refactors code. Minor behavior change - instead of --raw option, use --format=raw.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test January 30, 2022 22:01 Inactive
@github-actions
Copy link

Integration tests success for
[9d9f98e]
(https://github.com/ossf/scorecard/actions/runs/1769872120)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test January 30, 2022 22:48 Inactive
@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) January 30, 2022 22:51
@github-actions
Copy link

Integration tests success for
[77e2fbd]
(https://github.com/ossf/scorecard/actions/runs/1769973915)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test January 31, 2022 00:06 Inactive
@github-actions
Copy link

Integration tests success for
[d0f7b10]
(https://github.com/ossf/scorecard/actions/runs/1770138229)

naveensrinivasan
naveensrinivasan approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Few suggestions on the code. But I am OK if you think these aren't required from your perspective. Feel free to merge 👍

cmd/package_managers.go Outdated Show resolved Hide resolved
cmd/package_managers.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test January 31, 2022 01:08 Inactive
@github-actions
Copy link

Integration tests success for
[9d14f29]
(https://github.com/ossf/scorecard/actions/runs/1770309083)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test January 31, 2022 01:28 Inactive
@github-actions
Copy link

Integration tests success for
[4f67ddf]
(https://github.com/ossf/scorecard/actions/runs/1770358660)

laurentsimon
laurentsimon approved these changes Jan 31, 2022
View reviewed changes
clients/localdir/repo.go Show resolved Hide resolved
cmd/package_managers.go Show resolved Hide resolved
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test January 31, 2022 20:47 Inactive
@github-actions
Copy link

Integration tests success for
[032e16d]
(https://github.com/ossf/scorecard/actions/runs/1774830346)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test January 31, 2022 21:16 Inactive
@github-actions
Copy link

Integration tests success for
[e52bb08]
(https://github.com/ossf/scorecard/actions/runs/1774947742)

@azeemshaikh38 azeemshaikh38 merged commit 3995d31 into main Jan 31, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/cmd branch January 31, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@naveensrinivasan naveensrinivasan naveensrinivasan approved these changes

@inferno-chromium inferno-chromium Awaiting requested review from inferno-chromium

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azeemshaikh38 @naveensrinivasan @laurentsimon @azeemsgoogle