-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Remove ListMergedPRs API #1566
Conversation
af87dc0
to
5fc4c1d
Compare
Integration tests success for |
Integration tests success for |
Codecov Report
@@ Coverage Diff @@
## main #1566 +/- ##
==========================================
+ Coverage 54.12% 54.17% +0.04%
==========================================
Files 70 70
Lines 6169 6167 -2
==========================================
+ Hits 3339 3341 +2
+ Misses 2620 2614 -6
- Partials 210 212 +2 |
5fc4c1d
to
479a387
Compare
Integration tests success for |
479a387
to
b7fff68
Compare
Integration tests success for |
b7fff68
to
0a6d247
Compare
Integration tests success for |
0a6d247
to
fb3e449
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Thanks
Integration tests success for |
Friendly ping for a review. |
fb3e449
to
3afdd3a
Compare
Integration tests success for |
3afdd3a
to
7053e63
Compare
7053e63
to
ed4642a
Compare
ed4642a
to
a58ab56
Compare
a58ab56
to
c0a8c8d
Compare
Integration tests success for |
Integration tests success for |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Instead of relying on 2 potentially divergent APIs -
ListCommits
andListMergedPRs
, reduce the API to onlyListCommits
. Any PRs associated with this commit will be return in theassociatedPR
field. It makes Scorecard more tightly tied to analyzing a repo's commits (part of Commit based scorecard #575) and helps avoid confusion in future implementations ofRepoClient
(long-term fix of BUG: Checks using ListMergedPRs() need hardening #1524).Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes.