Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Remove ListMergedPRs API #1566

Merged
merged 1 commit into from
Feb 3, 2022
Merged

⚠️ Remove ListMergedPRs API #1566

merged 1 commit into from
Feb 3, 2022

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Instead of relying on 2 potentially divergent APIs - ListCommits and ListMergedPRs, reduce the API to only ListCommits. Any PRs associated with this commit will be return in the associatedPR field. It makes Scorecard more tightly tied to analyzing a repo's commits (part of Commit based scorecard #575) and helps avoid confusion in future implementations of RepoClient (long-term fix of BUG: Checks using ListMergedPRs() need hardening #1524).

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Yes.

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test January 30, 2022 07:51 Inactive
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test January 30, 2022 07:53 Inactive
@github-actions
Copy link

Integration tests success for
[af87dc0]
(https://github.com/ossf/scorecard/actions/runs/1768084213)

@github-actions
Copy link

Integration tests success for
[5fc4c1d]
(https://github.com/ossf/scorecard/actions/runs/1768086946)

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2022

Codecov Report

Merging #1566 (fb3e449) into main (86d8281) will increase coverage by 0.04%.
The diff coverage is 41.07%.

@@            Coverage Diff             @@
##             main    #1566      +/-   ##
==========================================
+ Coverage   54.12%   54.17%   +0.04%     
==========================================
  Files          70       70              
  Lines        6169     6167       -2     
==========================================
+ Hits         3339     3341       +2     
+ Misses       2620     2614       -6     
- Partials      210      212       +2     

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test January 30, 2022 23:02 Inactive
@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) January 30, 2022 23:02
@github-actions
Copy link

Integration tests success for
[479a387]
(https://github.com/ossf/scorecard/actions/runs/1769997586)

checks/ci_tests.go Outdated Show resolved Hide resolved
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 1, 2022 00:44 Inactive
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Integration tests success for
[b7fff68]
(https://github.com/ossf/scorecard/actions/runs/1775734336)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 1, 2022 19:19 Inactive
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Integration tests success for
[0a6d247]
(https://github.com/ossf/scorecard/actions/runs/1780250252)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 2, 2022 01:14 Inactive
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Thanks

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Integration tests success for
[fb3e449]
(https://github.com/ossf/scorecard/actions/runs/1781613996)

@azeemshaikh38 azeemshaikh38 mentioned this pull request Feb 2, 2022
2 tasks
@azeemshaikh38
Copy link
Contributor Author

Friendly ping for a review.

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 2, 2022 16:36 Inactive
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Integration tests success for
[3afdd3a]
(https://github.com/ossf/scorecard/actions/runs/1785032017)

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 2, 2022 23:38 Inactive
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Integration tests success for
[a58ab56]
(https://github.com/ossf/scorecard/actions/runs/1786770579)

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Integration tests success for
[c0a8c8d]
(https://github.com/ossf/scorecard/actions/runs/1786777859)

@azeemshaikh38 azeemshaikh38 merged commit 4581c36 into main Feb 3, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/commit branch February 3, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants