Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Unit tests for binary_artifact #1512

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

naveensrinivasan
Copy link
Member

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    BUG: unit tests #986

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test January 21, 2022 17:41 Inactive
@github-actions
Copy link

Integration tests success for
[ea050eb]
(https://github.com/ossf/scorecard/actions/runs/1729997381)

@codecov-commenter
Copy link

Codecov Report

Merging #1512 (ea050eb) into main (062e33b) will increase coverage by 0.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1512      +/-   ##
==========================================
+ Coverage   50.43%   51.21%   +0.77%     
==========================================
  Files          68       68              
  Lines        6069     6069              
==========================================
+ Hits         3061     3108      +47     
+ Misses       2807     2757      -50     
- Partials      201      204       +3     

checks/raw/binary_artifact_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by mistake

@azeemshaikh38 azeemshaikh38 self-requested a review January 21, 2022 18:15
checks/raw/binary_artifact_test.go Outdated Show resolved Hide resolved
checks/raw/binary_artifact_test.go Outdated Show resolved Hide resolved
@naveensrinivasan naveensrinivasan force-pushed the naveen/feat/binary_artifact-test branch from ea050eb to c151c95 Compare January 27, 2022 16:23
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test January 27, 2022 16:23 Inactive
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test January 27, 2022 16:26 Inactive
@github-actions
Copy link

Integration tests success for
[c151c95]
(https://github.com/ossf/scorecard/actions/runs/1757282833)

@github-actions
Copy link

Integration tests success for
[63a8d2f]
(https://github.com/ossf/scorecard/actions/runs/1757297323)

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@naveensrinivasan naveensrinivasan merged commit 17467c1 into main Jan 27, 2022
@naveensrinivasan naveensrinivasan deleted the naveen/feat/binary_artifact-test branch January 27, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants