✨ Raw data for code review check

[laurentsimon]

Add support for raw results for Branch-Protection check.
No breaking changes.
The hope is that we will be able t re-use the "commit" structure for SAST.

Output:

"commits": [
      {
        "committer": {
          "login": "dependabot[bot]"
        },
        "review": {
          "platform": {
            "name": "GitHub"
          },
          "authors": [
            {
              "login": "azeemshaikh38"
            }
          ],
          "merge-request": {
            "number": 1459,
            "author": {
              "login": "dependabot"
            }
          }
        }
      },
      {
        "committer": {
          "login": "justaugustus"
        },
        "review": {
          "platform": {
            "name": "GitHub"
          },
          "authors": [
            {
              "login": "azeemshaikh38"
            }
          ],
          "merge-request": {
            "number": 1502,
            "author": {
              "login": "justaugustus"
            }
          }
        }
      }
...

cc @jeffmendoza @asraa to give you some idea of what the raw results look like at the moment.

[github-actions]

Integration tests success for
[870905f]
(https://github.com/ossf/scorecard/actions/runs/1730196089)

[github-actions]

Integration tests success for
[284955b]
(https://github.com/ossf/scorecard/actions/runs/1730200303)

[github-actions]

Integration tests success for
[188f4e6]
(https://github.com/ossf/scorecard/actions/runs/1730433565)

[github-actions]

Integration tests success for
[e8069a3]
(https://github.com/ossf/scorecard/actions/runs/1730531963)

[azeemshaikh38]

@laurentsimon will look at the PR over the weekend or maybe Monday. If this is blocking you in any way, let me know and I can prioritize this.

[laurentsimon]

@laurentsimon will look at the PR over the weekend or maybe Monday. If this is blocking you in any way, let me know and I can prioritize this.

Monday's fine. I don't have work blocked on this PR, np.

[naveensrinivasan]

Tests are required for such a large feature change. We shouldn't merge up until that.

[laurentsimon]

Tests are required for such a large feature change. We shouldn't merge up until that.

we won't. Btw, the existing unit tests still pass. This PR does not changing the logics, it just re-factors the code.

[github-actions]

Integration tests success for
[7c88215]
(https://github.com/ossf/scorecard/actions/runs/1757929451)

[github-actions]

Integration tests success for
[e156162]
(https://github.com/ossf/scorecard/actions/runs/1785344396)

[github-actions]

Integration tests success for
[4b78a9c]
(https://github.com/ossf/scorecard/actions/runs/1785346973)

[github-actions]

Integration tests success for
[ce8bf30]
(https://github.com/ossf/scorecard/actions/runs/1785467385)

[github-actions]

Integration tests success for
[00d1917]
(https://github.com/ossf/scorecard/actions/runs/1785468099)

[codecov-commenter]

Codecov Report

Merging #1505 (2ad2c0e) into main (0670b8b) will decrease coverage by 2.59%.
The diff coverage is 1.83%.

@@            Coverage Diff             @@
##             main    #1505      +/-   ##
==========================================
- Coverage   54.42%   51.82%   -2.60%     
==========================================
  Files          70       72       +2     
  Lines        6175     6313     +138     
==========================================
- Hits         3361     3272      -89     
- Misses       2603     2836     +233     
+ Partials      211      205       -6     

[naveensrinivasan]

Codecov Report

Merging #1505 (00d1917) into main (009aa85) will decrease coverage by 2.59%.
The diff coverage is 1.83%.

@@            Coverage Diff             @@
##             main    #1505      +/-   ##
==========================================
- Coverage   54.42%   51.82%   -2.60%     
==========================================
  Files          70       72       +2     
  Lines        6175     6313     +138     
==========================================
- Hits         3361     3272      -89     
- Misses       2603     2836     +233     
+ Partials      211      205       -6     

@laurentsimon Disabled auto merge. How do we address this?

[github-actions]

Integration tests success for
[2ad2c0e]
(https://github.com/ossf/scorecard/actions/runs/1785668681)

[laurentsimon]

The bulk of the coverage drops appears to be from file checks/raw/code_review.go which shows with no hits. I've re-factored the code but not changed the logic. Why does it show no coverage? It's literally telling us none of the lines were tested. Do you know what's going on?

[naveensrinivasan]

The bulk of the coverage drops appears to be from file checks/raw/code_review.go which shows with no hits. I've re-factored the code but not changed the logic. Why does it show no coverage? It's literally telling us none of the lines were tested. Do you know what's going on?

TBH I don't know. If you think it is good, please merge it 👍

[laurentsimon]

The bulk of the coverage drops appears to be from file checks/raw/code_review.go which shows with no hits. I've re-factored the code but not changed the logic. Why does it show no coverage? It's literally telling us none of the lines were tested. Do you know what's going on?

TBH I don't know. If you think it is good, please merge it 👍

something is off but I don't know why codecov does not see it :/ Let's merge and please remind me to see what the following PRs show about these lines.

[github-actions]

Integration tests success for
[b9e798d]
(https://github.com/ossf/scorecard/actions/runs/1785788989)