-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 docs: add installation instructions for mac and linux #1378
Conversation
Integration tests success for |
You can use [Homebrew](https://brew.sh/) (on macOS or Linux) to install Scorecards. | ||
|
||
```sh | ||
brew install scorecard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this actually work? I thought we don't have homebrew setup. @developer-guy fyi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is an existing https://formulae.brew.sh/formula/scorecard#default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is also maintained by the community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, in that case do we need #1376?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this now. cc @developer-guy
|
||
| Package Manager | Linux Distribution | Command | | ||
|------------------------------------------------------------|--------------------|--------------------------------------------| | ||
| Nix | NixOS | `nix-env -iA nixpkgs.scorecard` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here. We don't have this setup AFAIK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was submitted to nixpkgs1 by @06kellyjac
Footnotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this is maintained by the community https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/security/scorecard/default.nix? This will help with the expectations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty much any package via a package manager is maintained by the "community", excluding the big businesses such as RedHat, OpenSUSE, Canonical
unless if you mean the distinction between the official arch repositories and the community AUR or the official brew repositories and separate casks. If that's the distinction we're using then this is an "official" package in the official nixpkgs, the AUR equivalent in nix/nixpkgs is the NUR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @06kellyjac!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,I am good with this. I will let @laurentsimon make a call.
You can use [Homebrew](https://brew.sh/) (on macOS or Linux) to install Scorecards. | ||
|
||
```sh | ||
brew install scorecard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is also maintained by the community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @JamieMagee !
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds installation instructions for HomeBrew, NixOS, and Arch Linux
What is the current behavior? (You can also link to an open issue here)
N/A
What is the new behavior (if this is a feature change)?
N/A
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: