Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix integration test #1318

Merged
merged 1 commit into from
Nov 20, 2021
Merged

🐛 Fix integration test #1318

merged 1 commit into from
Nov 20, 2021

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Nov 20, 2021

See this line https://github.com/ossf/scorecard/blob/main/.github/workflows/integration.yml#L36
We're not checking out the PR using ref, so we're effectively testing the main branch.

I unfortunately pushed a breaking change #1316

To merge it it, we will need to disable integration tests temporarily in the GitHub UX.

close #1317

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azeemshaikh38 azeemshaikh38 merged commit 67c5e93 into ossf:main Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: integration tests are not testing the PR code
2 participants