-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Pinned-Dependencies: Fix invalid shell file handling #1312
🐛 Pinned-Dependencies: Fix invalid shell file handling #1312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lehors !
Integration tests success for |
Integration tests success for |
Parsing errors are meant to be discarded but aren't. This patch changes the code so that the error is indeed discarded and checking continues as intended and adds a unit test for it. Signed-off-by: Arnaud J Le Hors <[email protected]>
7c139ad
to
50be3da
Compare
Integration tests success for |
Integration tests success for |
Integration tests success for |
Parsing errors are meant to be discarded but aren't. This patch
changes the code so that the error is indeed discarded and checking
continues as intended.
Signed-off-by: Arnaud J Le Hors [email protected]
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
See Issue Pinned_Dependencies check stops on faulty shell files when it is meant to continue #1307
What is the new behavior (if this is a feature change)?
The parsing error is discarded as intended and a score is given as a result.
The bottom of the description of Issue Pinned_Dependencies check stops on faulty shell files when it is meant to continue #1307 shows the new output.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No