Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 More nilptr issues #1296

Merged
merged 1 commit into from
Nov 18, 2021
Merged

🐛 More nilptr issues #1296

merged 1 commit into from
Nov 18, 2021

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Failing repos:
  • github.com/johnmcfarlane/cnl
  • github.com/shahoob/easePackageCheck
  • github.com/mongodb/atlas-osb
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) November 18, 2021 05:02
@github-actions
Copy link

Integration tests success for ec6174145805ed02a04e3b1b875aa14b0d065100

ristomcgehee
ristomcgehee approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@ristomcgehee ristomcgehee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry about all the nil ptr issues. I'm being more careful in my code now to check for nil.

@azeemshaikh38 azeemshaikh38 merged commit e15e7b1 into main Nov 18, 2021
@azeemshaikh38 azeemshaikh38 deleted the azeems/nilpotr branch November 18, 2021 05:27
@azeemshaikh38
Copy link
Contributor Author

Looks good. Sorry about all the nil ptr issues. I'm being more careful in my code now to check for nil.

No worries. Lets try and add some more unit tests so that these corner cases can be caught more easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ristomcgehee ristomcgehee ristomcgehee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azeemshaikh38 @ristomcgehee @azeemsgoogle