-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Update score for branch protection with levels #1287
Conversation
bed7c20
to
9c30ba6
Compare
friendly ping. ISE would like this check in the cron job's data in a couple weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to also comment offline as well..
Suggestions for wording this in checks.yaml (use This test has tiered scoring. Each tier must be fully satisfied to achieve points at the next tier. For example, if you fulfill the Tier 3 checks but do not fulfill all the Tier 2 checks, you will not receive any points for Tier 3. Note: If Scorecard is run without an administrative access token, the requirements that specify “For administrators” are ignored. Tier 1 Requirements (3/10 points):
Tier 2 Requirements (6/10 points):
Tier 3 Requirements (8/10 points):
Tier 4 Requirements (9/10 points):
Tier 5 Requirements (10/10 points):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the small comment nits
Thanks @asraa and @azeemsgoogle . Did not mean to be too pushy on this one... kinda came across this way though. @asraa please feel free to start an issue/PR to separate this check, if you're interested in tackling it. |
FYI |
6a04821
to
00a3e48
Compare
@naveensrinivasan @azeemshaikh38 please approve my integration tests. Thanks |
Note: the PR has 2 LGTMs but this does not trigger the automatic approval of the integration test :/ |
Looks like I'm able to approve my own integration tests! |
Integration tests success for |
Update score to work like 'stages':
If a stage is not satisfied, the score won't go up regardless of the settings of the next stages. Warn/Info messages are shown for all stage, regardless of the score.
I scorecard is run without admin access, the admin settings are ignored.
@olivekl how shall I word this in the checks.yaml?
FYI, I'm working on the unit tests right now but that should not hamper the review.