Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix integration test runs #1286

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

naveensrinivasan
Copy link
Member

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@github-actions
Copy link

Integration tests failure for 01bc60f0f545523891949dad5e97b2d24e4e3782

@azeemshaikh38 azeemshaikh38 mentioned this pull request Nov 17, 2021
2 tasks
@azeemshaikh38
Copy link
Contributor

Is this PR good to submit after #1291?

@naveensrinivasan
Copy link
Member Author

Is this PR good to submit after #1291?

I think so.

@azeemshaikh38
Copy link
Contributor

Is this PR good to submit after #1291?

I think so.

Ok, lets submit this then. We've had 3 different PRs break different e2e tests in a single day. We really need this asap.

Thanks Naveen!

@naveensrinivasan naveensrinivasan marked this pull request as ready for review November 17, 2021 03:14
@naveensrinivasan naveensrinivasan enabled auto-merge (squash) November 17, 2021 03:14
@github-actions
Copy link

Integration tests success for d5c55d7775f9676053ce1cf21214990c460cc344

@naveensrinivasan naveensrinivasan merged commit 0339eea into main Nov 17, 2021
@naveensrinivasan naveensrinivasan deleted the naveen/feat/fix-integration-test-runs branch November 17, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants