Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Use blob-based CII client #1284

Merged
merged 5 commits into from
Nov 18, 2021
Merged

✨ Use blob-based CII client #1284

merged 5 commits into from
Nov 18, 2021

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements

@github-actions
Copy link

Integration tests failure for 2574f8cf8f5bd543a95d1cd641ad0c3627839df5

@github-actions
Copy link

Integration tests success for cc79b64ab275f77d85e13ecd4b3d50fbcf832242

@github-actions
Copy link

Integration tests success for 3771e4f15c416ff24971c2abe284a5a6a7e2a1ab

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) November 17, 2021 03:52
@github-actions
Copy link

Integration tests success for ebf2d5d2eccffb029b44a837955371d3938c7873

@github-actions
Copy link

Integration tests success for 60012a3979f6e4eba9fe58320ba86cbf242972bd

@azeemshaikh38 azeemshaikh38 merged commit 89b316c into main Nov 18, 2021
@azeemshaikh38 azeemshaikh38 deleted the azeems/cii branch November 18, 2021 21:02
@david-a-wheeler
Copy link
Contributor

LGTM!

The issue is, how often will you update the database download? Weekly, or at most daily, should be adequate.

@azeemshaikh38
Copy link
Contributor Author

LGTM!

The issue is, how often will you update the database download? Weekly, or at most daily, should be adequate.

As of now it'll happen monthly. I'm assuming the data doesn't change too often?

@david-a-wheeler
Copy link
Contributor

Data changes far more often, but I think you just want to know "is a project pursuing a badge" & "does it have one".

Every day about 1-2 projects join, and occasionally a project gets a badge. Waiting up to a whole month to update seems very long.

I think a weekly download, at least for now, would be the best pace.

@azeemshaikh38
Copy link
Contributor Author

Data changes far more often, but I think you just want to know "is a project pursuing a badge" & "does it have one".

Every day about 1-2 projects join, and occasionally a project gets a badge. Waiting up to a whole month to update seems very long.

I think a weekly download, at least for now, would be the best pace.

Updated to run weekly in #1309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverchang oliverchang oliverchang approved these changes

@david-a-wheeler david-a-wheeler Awaiting requested review from david-a-wheeler

@naveensrinivasan naveensrinivasan Awaiting requested review from naveensrinivasan

@laurentsimon laurentsimon Awaiting requested review from laurentsimon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Improve CII-Best-Practices-Badge API access
4 participants
@azeemshaikh38 @david-a-wheeler @oliverchang @azeemsgoogle