✨SAST: no longer skip "neutral" checks #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some SASTs like LGTM don't analyze PRs where code hasn't been changed, which leads to their status being "neutral" there. It's a follow up to #1232 (comment) I'm not sure what to do about one-offs like the one mentioned in #1232 (comment) that shouldn't affect the aggregate score but it can probably be fixed later.
|
Thanks for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some SASTs like LGTM don't analyze PRs where code hasn't been changed,
which leads to their status being "neutral" there.
It's a follow up to #1232 (comment)
I'm not sure what to do about one-offs like the one
mentioned in #1232 (comment)
that shouldn't affect the aggregate score but it can probably
be fixed later.
cc @laurentsimon