-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove repos
package
#1191
🌱 Remove repos
package
#1191
Conversation
Integration tests success for c413f15d41ccde8ca48b80e960840d82a557e6fa |
c413f15
to
2af0811
Compare
Integration tests success for 2af081153b42176fb44fe63a8159fee3155eade0 |
Integration tests success for 7667f0cb5e7f9cba0b9b642d3e566ef9310a5b62 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on this PR. I really like the idea of removing repo_uri files. It felt redundant with client repo.
@@ -27,7 +27,6 @@ import ( | |||
"github.com/ossf/scorecard/v3/checks" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope of this PR: do we need the code in this file? Or shall we get rid of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm ok removing this too. @naveensrinivasan wdyt?
7667f0c
to
417570a
Compare
Integration tests success for 417570a7b87bc8dea43738e23f14c5453fdb0e5f |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Remove the
repos
package and replace it withclients.Repo
interface.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.