Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove repos package #1191

Merged
merged 1 commit into from
Oct 29, 2021
Merged

🌱 Remove repos package #1191

merged 1 commit into from
Oct 29, 2021

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Remove the repos package and replace it with clients.Repo interface.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@github-actions
Copy link

Integration tests success for c413f15d41ccde8ca48b80e960840d82a557e6fa

cron/data/format.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests success for 2af081153b42176fb44fe63a8159fee3155eade0

@github-actions
Copy link

Integration tests success for 7667f0cb5e7f9cba0b9b642d3e566ef9310a5b62

Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this PR. I really like the idea of removing repo_uri files. It felt redundant with client repo.

cmd/root.go Show resolved Hide resolved
@@ -27,7 +27,6 @@ import (
"github.com/ossf/scorecard/v3/checks"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of scope of this PR: do we need the code in this file? Or shall we get rid of it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm ok removing this too. @naveensrinivasan wdyt?

@github-actions
Copy link

Integration tests success for 417570a7b87bc8dea43738e23f14c5453fdb0e5f

@azeemshaikh38 azeemshaikh38 merged commit 83649a7 into main Oct 29, 2021
@azeemshaikh38 azeemshaikh38 deleted the azeems/repourl branch October 29, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants