Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix ListFiles caching in localrepo client #1190

Merged
merged 4 commits into from
Oct 29, 2021

Conversation

laurentsimon
Copy link
Contributor

  • Please check if the PR fulfills these requirements
--- FAIL: TestClient_CreationAndCaching (0.00s)
    --- FAIL: TestClient_CreationAndCaching/repo_0 (0.02s)
        client_test.go:105: Got diff:   []string{
            - 	"file0",
            - 	"dir1/file1",
            - 	"dir1/dir2/file2",
              }
  • What is the new behavior (if this is a feature change)?
    tests pass

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@laurentsimon laurentsimon enabled auto-merge (squash) October 29, 2021 00:50
@azeemshaikh38
Copy link
Contributor

Can you incorporate the changes from #1187 too?

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

clients/localdir/client.go Outdated Show resolved Hide resolved
@laurentsimon
Copy link
Contributor Author

Can you incorporate the changes from #1187 too?

absolutely. Closing it.

laurentsimon and others added 2 commits October 29, 2021 01:57
@laurentsimon laurentsimon merged commit 6088669 into ossf:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants