Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update shard naming to allow for 1M+ shards #1170

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Update shard naming convention to allow for >100k shards.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@github-actions
Copy link

Integration tests success for 47db863221cdf16de4b07cc75696b42e5e57ad59

Copy link
Contributor

@inferno-chromium inferno-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can even do %07d :)

@azeemshaikh38
Copy link
Contributor Author

Can even do %07d :)

Done

@github-actions
Copy link

Integration tests success for d2895679a831b18117dd817260beacf5246b76da

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) October 28, 2021 18:44
@github-actions
Copy link

Integration tests success for d6f78f37a8c1c2ea834c793d53ad5799ace1a12e

@azeemshaikh38 azeemshaikh38 merged commit 8735961 into main Oct 28, 2021
@azeemshaikh38 azeemshaikh38 deleted the azeems/shards branch October 28, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants