Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Included arm64 release for darwin #1157

Merged
merged 2 commits into from
Oct 25, 2021
Merged

🌱 Included arm64 release for darwin #1157

merged 2 commits into from
Oct 25, 2021

Conversation

naveensrinivasan
Copy link
Member

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

Fixes #1155

@naveensrinivasan naveensrinivasan self-assigned this Oct 24, 2021
@github-actions
Copy link

Integration tests success for d96191399f77b689b56783373950f2371ca1edf8

azeemshaikh38
azeemshaikh38 reviewed Oct 25, 2021
View reviewed changes
.goreleaser.yml Outdated Show resolved Hide resolved
@naveensrinivasan naveensrinivasan force-pushed the naveensrinivasan/go-releaser-darwin-arm64 branch from d961913 to b2c7b23 Compare October 25, 2021 15:13
@github-actions
Copy link

Integration tests success for b2c7b232e15e54b7c761ee635c91e63f801caddc

@github-actions
Copy link

Integration tests success for 1ec842952e2902fc673132ce2de69e111956bba5

azeemshaikh38
azeemshaikh38 approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@naveensrinivasan
Copy link
Member Author

@azeemshaikh38 @laurentsimon Tuned off the Validate requirement for merging as there are broken unit tests.

@naveensrinivasan naveensrinivasan merged commit c3d51a7 into main Oct 25, 2021
@naveensrinivasan naveensrinivasan deleted the naveensrinivasan/go-releaser-darwin-arm64 branch October 25, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeemshaikh38 azeemshaikh38 azeemshaikh38 approved these changes

@laurentsimon laurentsimon Awaiting requested review from laurentsimon

Assignees

@naveensrinivasan naveensrinivasan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature - Scorecard release for Darwin arm64
2 participants
@naveensrinivasan @azeemshaikh38