Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in name of dependency update bot: Renovate #2568

Closed
HonkingGoose opened this issue Dec 25, 2022 · 1 comment · Fixed by #2569
Closed

Typo in name of dependency update bot: Renovate #2568

HonkingGoose opened this issue Dec 25, 2022 · 1 comment · Fixed by #2569
Assignees
Labels
kind/bug Something isn't working

Comments

@HonkingGoose
Copy link

Describe the bug

Spelling error in name of dependency bot in these file(s):

Expect(scut.ValidateTestReturn(nil, "renovabot", &expected, &result, &dl)).Should(BeTrue())

Reproduction steps

Steps to reproduce the behavior:

  1. Open the ossf/scorecard repository
  2. Search for string Renovabot
  3. Find these two files

The bad spelling also shows up in the response body:

curl -X 'GET' \
  'https://api.securityscorecards.dev/projects/github.com/renovatebot/renovate' \
  -H 'accept: application/json'
    {
      "name": "Dependency-Update-Tool",
      "score": 10,
      "reason": "update tool detected",
      "details": [
        "Info: Renovabot detected: renovate.json:1"
      ],
      "documentation": {
        "short": "Determines if the project uses a dependency update tool.",
        "url": "https://github.com/ossf/scorecard/blob/c61f6bc297ee71dc4b5f2511144d6c031b946089/docs/checks.md#dependency-update-tool"
      }
    },

Expected behavior

Change Renovabot to Renovate.

Additional context

I don't know how hard it is for a newcomer to fix this problem? It looks like I can just rename the two entries in the files, and then create a PR?

Related issue:

@HonkingGoose HonkingGoose added the kind/bug Something isn't working label Dec 25, 2022
@azeemshaikh38
Copy link
Contributor

@naveensrinivasan would you be able to take this on?

naveensrinivasan added a commit that referenced this issue Dec 26, 2022
- Fix typo in renovatebot
- Fixes #2568

Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan added a commit that referenced this issue Dec 27, 2022
- Fix typo in renovatebot
- Fixes #2568

Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan added a commit that referenced this issue Dec 27, 2022
- Fix typo in renovatebot
- Fixes #2568

Signed-off-by: naveensrinivasan <[email protected]>

Signed-off-by: naveensrinivasan <[email protected]>
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this issue Feb 9, 2023
- Fix typo in renovatebot
- Fixes ossf#2568

Signed-off-by: naveensrinivasan <[email protected]>

Signed-off-by: naveensrinivasan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants