Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: replace the head by commitSHA/version tag to specify a version when checking the dependency-diff #2065

Closed
aidenwang9867 opened this issue Jul 15, 2022 · 5 comments
Labels
kind/enhancement New feature or request Stale

Comments

@aidenwang9867
Copy link
Contributor

aidenwang9867 commented Jul 15, 2022

Is your feature request related to a problem? Please describe.
In v0 (issue #2008, PR #2030, #2046, #2077), we use the default headSHA of the dependency repo to check and report its security state. However, this is somehow imprecise since users use different versions of dependencies (so it doesn't have to be the version in the head commit).

Describe the solution you'd like
Use the incoming scorecard REST API that supports scorecard results fetching by either a commitSHA or a version tag to replace the default headSHA (HEAD), in order to better report the security states of users' dependency changes.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
This is a TODO introduced in PR #2046.

@aidenwang9867 aidenwang9867 added the kind/enhancement New feature or request label Jul 15, 2022
@aidenwang9867 aidenwang9867 changed the title Feature Feature: replacing headSHA by commitSHA when checking the dependency-diff's repo Jul 15, 2022
@aidenwang9867 aidenwang9867 changed the title Feature: replacing headSHA by commitSHA when checking the dependency-diff's repo Feature: replace headSHA by commitSHA when checking the dependency-diff's repo Jul 15, 2022
@aidenwang9867 aidenwang9867 changed the title Feature: replace headSHA by commitSHA when checking the dependency-diff's repo Feature: replace the head by commitSHA/version tag to specify a version when checking the dependency-diff Jul 20, 2022
@aidenwang9867
Copy link
Contributor Author

aidenwang9867 commented Aug 26, 2022

We might not have this implemented until (1) the Scorecard REST API supports query by a version tag or (2) the GitHub Dependency Review API returns the commitSHA of a dependency.

@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity.

Copy link

This issue is stale because it has been open for 60 days with no activity.

Copy link

github-actions bot commented May 3, 2024

This issue has been marked stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the Stale label May 3, 2024
@spencerschrock
Copy link
Member

#2008 (comment)

@spencerschrock spencerschrock closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request Stale
Projects
Status: Done
Development

No branches or pull requests

3 participants