Skip to content

Commit

Permalink
docs(branch-protection-check): adapt check description to consider re…
Browse files Browse the repository at this point in the history
…quirement of require PRs to make changes

It adds the new tier 2 requirement, but also specify that the
"require at least 1 reviewer" will have doubled weight.

Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
  • Loading branch information
diogoteles08 committed Sep 20, 2023
1 parent 22e0eef commit a147723
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion docs/checks.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ Tier 1 Requirements (3/10 points):
- For administrators: Include administrator for review

Tier 2 Requirements (6/10 points):
- Require at least 1 reviewer for approval before merging
- For administrators: Require PRs prior to make any code changes
- Require at least 1 reviewer for approval before merging (for administrators, this requirement weights twice than the others in this tier)
- For administrators: Require branch to be up to date before merging
- For administrators: Require approval of the most recent reviewable push

Expand Down
3 changes: 2 additions & 1 deletion docs/checks/internal/checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,8 @@ checks:
- For administrators: Include administrator for review
Tier 2 Requirements (6/10 points):
- Require at least 1 reviewer for approval before merging
- For administrators: Require PRs prior to make any code changes
- Require at least 1 reviewer for approval before merging (for administrators, this requirement weights twice than the others in this tier)
- For administrators: Require branch to be up to date before merging
- For administrators: Require approval of the most recent reviewable push
Expand Down

0 comments on commit a147723

Please sign in to comment.