Fix sorting contributors before comparing in test (#4455)

The intention was always to sort, but the wrong sort function was used. This led to an unsorted list, which was dependent on map iteration order, leading to flaky unit tests. This was reproducible with go test when passing a large --count option. Signed-off-by: Spencer Schrock <[email protected]>
ossf · Dec 12, 2024 · 2409124 · 2409124
1 parent 52b3bad
commit 2409124
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/clients/azuredevopsrepo/contributors_test.go b/clients/azuredevopsrepo/contributors_test.go
@@ -122,7 +122,8 @@ func Test_listContributors(t *testing.T) {
 				t.Errorf("contributorsHandler.setup() error = %v, wantErr %v", err, tt.wantErr)
 				return
 			}
-			if diff := cmp.Diff(tt.wantContribs, c.contributors, cmpopts.SortSlices(func(a, b string) bool { return a < b })); diff != "" {
+			sortUsers := func(a, b clients.User) bool { return a.Login < b.Login }
+			if diff := cmp.Diff(tt.wantContribs, c.contributors, cmpopts.SortSlices(sortUsers)); diff != "" {
 				t.Errorf("contributorsHandler.setup() mismatch (-want +got):\n%s", diff)
 			}
 		})