log negative findings

Signed-off-by: AdamKorcz <[email protected]>
ossf · Oct 11, 2023 · 148801e · 148801e
1 parent 099185c
commit 148801e
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/checks/evaluation/finding.go b/checks/evaluation/finding.go
@@ -29,3 +29,14 @@ func nonNegativeFindings(findings []finding.Finding) []finding.Finding {
 	}
 	return ff
 }
+
+func negativeFindings(findings []finding.Finding) []finding.Finding {
+	var ff []finding.Finding
+	for i := range findings {
+		f := &findings[i]
+		if f.Outcome == finding.OutcomeNegative {
+			ff = append(ff, *f)
+		}
+	}
+	return ff
+}
diff --git a/checks/evaluation/packaging.go b/checks/evaluation/packaging.go
@@ -47,6 +47,6 @@ func Packaging(name string,
 		}
 	}
 
-	checker.LogFindings(nonNegativeFindings(findings), dl)
+	checker.LogFindings(negativeFindings(findings), dl)
 	return checker.CreateMinScoreResult(name, "project is not published as package")
 }
diff --git a/checks/evaluation/packaging_test.go b/checks/evaluation/packaging_test.go
@@ -64,7 +64,8 @@ func TestPackaging(t *testing.T) {
 				},
 			},
 			result: scut.TestReturn{
-				Score: checker.MinResultScore,
+				Score:        checker.MinResultScore,
+				NumberOfWarn: 1,
 			},
 		},
 		{

diff --git a/probes/entries.go b/probes/entries.go
@@ -30,7 +30,6 @@ import (
 	"github.com/ossf/scorecard/v4/probes/fuzzedWithPythonAtheris"
 	"github.com/ossf/scorecard/v4/probes/fuzzedWithRustCargofuzz"
 	"github.com/ossf/scorecard/v4/probes/fuzzedWithSwiftLibFuzzer"
-	"github.com/ossf/scorecard/v4/probes/packagedWithGithubActions"
 	"github.com/ossf/scorecard/v4/probes/packagedNpmWithGitHubWorkflow"
 	"github.com/ossf/scorecard/v4/probes/securityPolicyContainsLinks"
 	"github.com/ossf/scorecard/v4/probes/securityPolicyContainsText"