Skip to content

Commit

Permalink
comments
Browse files Browse the repository at this point in the history
  • Loading branch information
laurentsimon committed Mar 18, 2022
1 parent 36f28fc commit 0fa9c3d
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions cron/config/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@ metric-exporter: stackdriver
result-data-bucket-url-v2: gs://ossf-scorecard-data2
bigquery-table-v2: scorecard-v2
# Raw results.
raw-result-data-bucket-url-v0: gs://ossf-scorecard-rawdata-v0
raw-bigquery-table-v0: scorecard-rawdata-v0
raw-result-data-bucket-url: gs://ossf-scorecard-rawdata
raw-bigquery-table: scorecard-rawdata
4 changes: 2 additions & 2 deletions cron/k8s/controller.release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ spec:
# UPGRADEv2: to remove.
- name: SCORECARD_DATA_BUCKET_URLV2
value: "gs://ossf-scorecard-data-releasetest2"
# Raw results v0.
# Raw results.
- name: RAW_SCORECARD_DATA_BUCKET_URL
value: "gs://ossf-scorecard-rawdata-releasetest-v0"
value: "gs://ossf-scorecard-rawdata-releasetest"
- name: SCORECARD_SHARD_SIZE
value: "5"
resources:
Expand Down
8 changes: 4 additions & 4 deletions cron/k8s/transfer-raw.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
apiVersion: batch/v1
kind: CronJob
metadata:
name: scorecard-bq-raw-transfer-v0
name: scorecard-bq-raw-transfer
spec:
# At 02:00UTC on Monday and Thursday.
schedule: "0 2 * * 1,4"
Expand All @@ -25,7 +25,7 @@ spec:
template:
spec:
containers:
- name: bq-raw-transfer-v0
- name: bq-raw-transfer
image: gcr.io/openssf/scorecard-bq-transfer:latest
imagePullPolicy: Always
resources:
Expand All @@ -35,7 +35,7 @@ spec:
memory: 1Gi
env:
- name: RAW_SCORECARD_BIGQUERY_TABLE
value: "scorecard-rawdata-v0"
value: "scorecard-rawdata"
- name: RAW_SCORECARD_DATA_BUCKET_URL
value: "gs://ossf-scorecard-rawdata-v0"
value: "gs://ossf-scorecard-rawdata"
restartPolicy: OnFailure
8 changes: 4 additions & 4 deletions cron/k8s/transfer.release-raw.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
apiVersion: batch/v1
kind: CronJob
metadata:
name: scorecard-bq-transfer-raw-releasetest-v0
name: scorecard-bq-transfer-raw-releasetest
spec:
# Daily at 9am and 6pm PST.
schedule: "0 1,16 * * *"
Expand All @@ -26,14 +26,14 @@ spec:
spec:
restartPolicy: OnFailure
containers:
- name: bq-transfer-raw-releasetest-v0
- name: bq-transfer-raw-releasetest
image: gcr.io/openssf/scorecard-bq-transfer:latest
imagePullPolicy: Always
env:
- name: RAW_SCORECARD_DATA_BUCKET_URL
value: "gs://ossf-scorecard-rawdata-releasetest-v0"
value: "gs://ossf-scorecard-rawdata-releasetest"
- name: RAW_SCORECARD_BIGQUERY_TABLE
value: "scorecard_raw-releasetest-v0"
value: "scorecard_raw-releasetest"
- name: SCORECARD_COMPLETION_THRESHOLD
value: "0.9"
resources:
Expand Down
2 changes: 1 addition & 1 deletion cron/k8s/worker.release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
- name: SCORECARD_DATA_BUCKET_URLV2
value: "gs://ossf-scorecard-data-releasetest2"
- name: RAW_SCORECARD_DATA_BUCKET_URL
value: "gs://ossf-scorecard-rawdata-releasetest-v0"
value: "gs://ossf-scorecard-rawdata-releasetest"
- name: SCORECARD_REQUEST_SUBSCRIPTION_URL
value: "gcppubsub://projects/openssf/subscriptions/scorecard-batch-worker-releasetest"
- name: SCORECARD_BLACKLISTED_CHECKS
Expand Down
4 changes: 2 additions & 2 deletions cron/worker/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ func processRequest(ctx context.Context,
return fmt.Errorf("error during result.AsJSON2: %w", err)
}

// Raw result v0.
// Raw result.
if err := format.AsRawJSON(&result, &rawBuffer); err != nil {
return fmt.Errorf("error during result.AsRawJSON: %w", err)
}
Expand All @@ -151,7 +151,7 @@ func processRequest(ctx context.Context,
return fmt.Errorf("error during WriteToBlobStore2: %w", err)
}

// Raw result v0.
// Raw result.
if err := data.WriteToBlobStore(ctx, rawBucketURL, filename, rawBuffer.Bytes()); err != nil {
return fmt.Errorf("error during WriteToBlobStore2: %w", err)
}
Expand Down

0 comments on commit 0fa9c3d

Please sign in to comment.