Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(viewer): slice the params.uri string in a way to allow for multi-… #701

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

stexandev
Copy link
Contributor

@stexandev stexandev commented Nov 6, 2024

…level groups

this is required to display results for repositories in multi-level groups, which is a feature in gitlab

Fixes #700

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for ossf-scorecard canceled.

Name Link
🔨 Latest commit 8892a25
🔍 Latest deploy log https://app.netlify.com/sites/ossf-scorecard/deploys/672b700c9bbf1000084cddf5

…level groups

this is required to display results for repositories in multi-level groups, which is a feature in gitlab

Signed-off-by: Stefan Hynek <[email protected]>
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the deploy preview, the request is for the right URL now

Request URL:
https://api.scorecard.dev/projects/gitlab.gwdg.de/subugoe/emo/tido
Request Method:
GET
Status Code:
404 Not Found

scorecards-site/static/viewer/index.html Show resolved Hide resolved
@spencerschrock spencerschrock merged commit f2aaf2e into ossf:main Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenSSF Scorecard report viewer does not handle nested gitlab groups correctly
2 participants