-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix null default branch/private fields #75
Conversation
@ChrisCarini please verify that this fixes the problem. Use I'll push the changes/new version one you've confirmed. Thanks for your patience! |
We need to find a better way to do integration tests. Could we prioritize it for this quarter? |
yes, I totally agree. @naveensrinivasan and I will chat next week. There's some low-hanging fruit we can do in the next couple weeks. I'll create an issue with a list of tests we can start with and that should give us good coverage. |
…`uses: laurentsimon/scorecard-action@bug/defaultbranch` for ossf/scorecard-action#75.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a suggestion to reduce the calls - please consider accepting the suggestion into this PR! 😄
Brief testing notes below:
- Switched workflow to use @laurentsimon 's bug branch (commit ref)
- Observe results
push
workflow execution: ✅ Success (ref)workflow_dispatch
workflow execution formaster
branch (default branch of this repo): ✅ Success (ref)workflow_dispatch
workflow execution foraddIconDir
branch (non-default branch): ✅ Failure (expected; non-default branch not supported per failure message) (ref)
…h` for ossf/scorecard-action#75." This reverts commit 4250e35.
Co-authored-by: Chris Carini <[email protected]>
The
repository.private
andrepository.default_branch
are null when the action is triggered by aschedule
trigger.I think this is a bug and I've created a support issue on GitHub to ask.
There is another field
master_branch
but it may be deprecated in the future so I would like to avoid it.To fix the issue, I'm querying a REST API instead, which seems more reliable.
closes #73