Fixups for golang-based entrypoint #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 69.02% 74.80% +5.77%
==========================================
Files 2 2
Lines 113 127 +14
==========================================
+ Hits 78 95 +17
+ Misses 27 25 -2
+ Partials 8 7 -1
|
There was a problem hiding this comment.
LGTM overall. Will let @justaugustus and @laurentsimon also take a look.
justaugustus
requested changes
Mar 10, 2022
laurentsimon
approved these changes
Mar 10, 2022
azeemshaikh38
approved these changes
Mar 15, 2022
naveensrinivasan
approved these changes
Mar 15, 2022
justaugustus
requested changes
Mar 15, 2022
|
@rohankh532 -- I've got a few more review comments, but I'll issue them as pushes to your branch to speed things along! |
Co-authored-by: Stephen Augustus (he/him) <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
justaugustus
changed the title
justaugustus
added a commit
to justaugustus/scorecard
that referenced
this pull request
May 26, 2022
- (Makefile) Created a makefile for building scorecard-action - (entrypoint.go) Changed resultsFilePath so that it is under the GithubWorkspace dir to fix file permission errors - (options.go) Properly pull & set EnvInputResultsFormat, EnvInputResultsFile, and EnvGithubAuthToken env vars - (options_test.go) Set EnvInputResultsFormat and EnvInputResultsFile before calling options.New() to see if it properly picks up env vars. Co-authored-by: Stephen Augustus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Dockerfile) Fixed the dockerfile so that it uses the new golang entrypoint instead of entrypoint.shupdate later(Dockerfile, options.go) Fixed the defaultScorecardPolicyFile not being copiedupdate later