Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip arch from version and deduplicate arch agnostic packages #294

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

jasinner
Copy link
Contributor

@jasinner jasinner commented Oct 15, 2024

Including the arch suffix in a fixed version can cause false positives if the wrong arch range is used to scan a system.

For example

0:7.3.0-427.28.1.el9_4.aarch64 < 0:7.3.0-427.28.1.el9_4.ppc64le

So 0:7.3.0-427.28.1.el9_4.aarch64 would match the 0..0:7.3.0-427.28.1.el9_4.ppc64le range and be considered vulnerable

Copy link
Collaborator

@andrewpollock andrewpollock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have the (unintended?) consequence of making it impossible to reason about source-versus-binary RPM vulnerabilities?

@andrewpollock
Copy link
Collaborator

Does this have the (unintended?) consequence of making it impossible to reason about source-versus-binary RPM vulnerabilities?

Discussed in person. Decided to cross this bridge if and when a concrete use case for source-versus-binary package scanning presents itself. Realistically, this shouldn't be expressed in the version string.

@jasinner jasinner marked this pull request as draft October 15, 2024 05:38
@jasinner
Copy link
Contributor Author

Putting this in draft while I test for any runtime errors on the CSAF data set.

@jasinner jasinner marked this pull request as ready for review October 17, 2024 04:51
@andrewpollock andrewpollock merged commit 3b28326 into ossf:main Oct 17, 2024
1 check passed
@abdosalamaljanad
Copy link

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants