Remove CVSS validation #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on conversation on ossf#168, the CVSS validation by pure regex is too strict, so remove. Fixes: ossf#168 Signed-off-by: Andrew Pollock <[email protected]>
oliverchang
approved these changes
Jul 18, 2023
chrisbloom7
approved these changes
Jul 18, 2023
oliverchang
pushed a commit
that referenced
this pull request
Nov 30, 2023
This PR comes to unlock #166 which seems stuck. ## What does it bring ? Basic support of CVSS v4.0, I'll open another issue about #178 about validating the CVSS vectors soon, as the FIRST.ORG SIG CVSS provide official CVSS validation regex we could use for schema validation. The string representation (aka vector) example comes from the CVSS v4.0 Specification Document Section 7. Signed-off-by: Lucas TESSON <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on conversation on #168, the CVSS validation by pure regex is too strict, so remove.
Fixes: #168