rename checks

Signed-off-by: Holly Gong <[email protected]>

tools/osv-linter/internal/checks/checks.go

@@ -91,7 +91,7 @@ var Collections = []CheckCollection{
 		Name:        "ALL",
 		Description: "all checks currently defined",
 		Checks: []*CheckDef{
-			CheckAffectedFieldValid,
+			CheckRecordHasAffected,
 			CheckRangeHasIntroducedEvent,
 			CheckRangeIsDistinct,
 			CheckPackageExists,
@@ -103,7 +103,7 @@ var Collections = []CheckCollection{
 		Name:        "offline",
 		Description: "checks that do not have remote data dependencies",
 		Checks: []*CheckDef{
-			CheckAffectedFieldValid,
+			CheckRecordHasAffected,
 			CheckRangeHasIntroducedEvent,
 			CheckRangeIsDistinct,
 			CheckPackagePurlValid,

tools/osv-linter/internal/checks/record.go

@@ -0,0 +1,21 @@
+package checks
+
+import (
+	"github.com/tidwall/gjson"
+)
+
+var CheckRecordHasAffected = &CheckDef{
+	Code:        "A0001",
+	Name:        "affected-data-exists",
+	Description: "every record has affected data",
+	Check:       RecordHasAffected,
+}
+
+// RecordHasAffected checks if the 'affected' field exists in the JSON and is not an empty array.
+func RecordHasAffected(json *gjson.Result, config *Config) (findings []CheckError) {
+	affectedEntries := json.Get("affected")
+	if !affectedEntries.Exists() || affectedEntries.String() == "[]" {
+		findings = append(findings, CheckError{Message: "Invalid Affected: affected filed cannot be null or empty"})
+	}
+	return findings
+}

tools/osv-linter/internal/checks/affected_test.go → tools/osv-linter/internal/checks/record_test.go

@@ -42,9 +42,9 @@ func TestAffectedField(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			gotFindings := AffectedFieldValid(tt.args.json, &Config{Verbose: true})
+			gotFindings := RecordHasAffected(tt.args.json, &Config{Verbose: true})
 			if diff := cmp.Diff(tt.wantFindings, gotFindings, cmpopts.EquateErrors()); diff != "" {
-				t.Errorf("AffectedFieldValid() mismatch (-want +got):\n%s", diff)
+				t.Errorf("RecordHasAffected() mismatch (-want +got):\n%s", diff)
 			}
 		})
 	}