Tweaks2 #18
Merged
Tweaks2 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove weird heading-1 "TL/DL" line which doesn't belong there. Maybe it was supposed to be "TLDR", but it's still wrong, and it's the wrong heading level anyway (this uses heading1=title). Removing it seems like the best course. Signed-off-by: David A. Wheeler <[email protected]>
Fixed some spelling errors, removed trailing spaces, and inserted a definition of "vulnerability reporter" (which was oddly missing). Signed-off-by: David A. Wheeler <[email protected]>
Signed-off-by: David A. Wheeler <[email protected]>
The subheadings of the second section had wildly different grammar types. Make them all verb-object. Signed-off-by: David A. Wheeler <[email protected]>
Briefly discuss withholding info about the vulnerability fix has been posted. Signed-off-by: David A. Wheeler <[email protected]>
Git is extremely popular, but not the only VCS in use. We should provide general guidance, & then specifics for common cases. Signed-off-by: David A. Wheeler <[email protected]>
Signed-off-by: David A. Wheeler <[email protected]>
I think this is a mistake that somehow carried over. Signed-off-by: David A. Wheeler <[email protected]>
Signed-off-by: David A. Wheeler <[email protected]>
Signed-off-by: David A. Wheeler <[email protected]>
The easiest time to publish the process is after you've made the decisions, so I think it's better placed a little earlier. Signed-off-by: David A. Wheeler <[email protected]>
Most other headings start with a verb (they're active); do the same thing here. Signed-off-by: David A. Wheeler <[email protected]>
Add the word "publicly* to make it clear that's the distinguishing factor. Signed-off-by: David A. Wheeler <[email protected]>
It wasn't clear what the pronouns referred to, and overall the text was confusing. I reordered & tweaked the text here; I don't think I changed the meaning, but hopefully I made it clearer. Signed-off-by: David A. Wheeler <[email protected]>
Signed-off-by: David A. Wheeler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tweaks, e.g., spelling fixes, etc.