[Unit Testing]: More test cases #647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurscchan
force-pushed
the
more-test-cases
branch
6 times, most recently
from
5c3693b to
06f085e
Compare
added 7 commits
November 30, 2022 22:45
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
arthurscchan
force-pushed
the
more-test-cases
branch
from
06f085e to
da5b573
Compare
arthurscchan
changed the title
Signed-off-by: Arthur Chan <[email protected]>
DavidKorczynski
requested changes
Dec 1, 2022
| } | ||
|
|
||
| @Test | ||
| public void sampleTestCases() throws IOException, InterruptedException { |
There was a problem hiding this comment.
I'm not sure about this test. The problem is that it may become a somewhat blocker of progress. Down the line, if we start to extend how the output looks, then this will fail even though semantics are intact. I feel like the tests should be rooted in semantic rather than syntax -- and this one compares two outputs in a string comparison fashion.
I think the easiest approach is to make the test a bit more narrow and focus on making the tests check that certain properties hold.
WDYT?
There was a problem hiding this comment.
I agree. And new unitesting has been pushed in PR #663
|
Not needed anymore, using another approach in PR #663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more unit testing test cases.
Related to issue #630 and extending PR #643
Signed-off-by: Arthur Chan [email protected]