Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JVM issue] Fix link bug #640

Merged
merged 6 commits into from
Nov 29, 2022
Merged

Conversation

arthurscchan
Copy link
Contributor

In optimal_targets.py (https://github.com/ossf/fuzz-introspector/blob/main/src/fuzz_introspector/analyses/optimal_targets.py#L259-L264), it uses some logic to determine the coverage source report link for a specific functions. But the logic is only suitable for c-cpp.

In fuzzer_profile.py, there is helper functions to handle coverage source report link for c-cpp / python / jvm separately. To reduce code duplication and to allow optimal function table to use the same coverage link resolve function, this PR move the coverage link resolve code to utils and allows both fuzzer_profile.py and optimal_targets.py to use it.

Related to issue #629 and also fixing bugs for python report.

Arthur Chan added 2 commits November 28, 2022 21:18
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
@evverx
Copy link
Contributor

evverx commented Nov 28, 2022

Looks like #639 and #638 were reverted when I assume the conflicts were resolved automatically during a rebase or something like that. It would be great if it was possible to bring them back.

Copy link
Contributor

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arthurscchan please check the latest changes from fuzz-introspector are intact

Arthur Chan added 2 commits November 29, 2022 01:15
Signed-off-by: Arthur Chan <[email protected]>
@arthurscchan
Copy link
Contributor Author

arthurscchan commented Nov 29, 2022

Changes from PR #638 and #639 are merged in.

@DavidKorczynski DavidKorczynski merged commit 4b4c68d into ossf:main Nov 29, 2022
@arthurscchan arthurscchan deleted the fix-link-bug branch December 15, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants