-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JVM issue] Fix link bug #640
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
arthurscchan
force-pushed
the
fix-link-bug
branch
from
November 28, 2022 21:42
a70f529
to
6671a99
Compare
Signed-off-by: Arthur Chan <[email protected]>
arthurscchan
force-pushed
the
fix-link-bug
branch
from
November 28, 2022 21:45
6671a99
to
9a328cb
Compare
Signed-off-by: Arthur Chan <[email protected]>
DavidKorczynski
requested changes
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arthurscchan please check the latest changes from fuzz-introspector are intact
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
DavidKorczynski
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In optimal_targets.py (https://github.com/ossf/fuzz-introspector/blob/main/src/fuzz_introspector/analyses/optimal_targets.py#L259-L264), it uses some logic to determine the coverage source report link for a specific functions. But the logic is only suitable for c-cpp.
In fuzzer_profile.py, there is helper functions to handle coverage source report link for c-cpp / python / jvm separately. To reduce code duplication and to allow optimal function table to use the same coverage link resolve function, this PR move the coverage link resolve code to utils and allows both fuzzer_profile.py and optimal_targets.py to use it.
Related to issue #629 and also fixing bugs for python report.