Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java-Integration]: Coverage report #612

Merged
merged 16 commits into from
Nov 22, 2022

Conversation

arthurscchan
Copy link
Contributor

Generate Jacoco coverage report and link to the fuzz-introspector call tree.
Related to Steps 5~6 of issue #536

@arthurscchan
Copy link
Contributor Author

Two separate items to be done in this PR.

  1. Create links to the details coverage report for each of the items in the fuzz-introspector call tree.
  2. Extract the coverage report items and stored in the coverage object for further processing and composition of data.

Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
@arthurscchan arthurscchan marked this pull request as ready for review November 21, 2022 21:17
Copy link
Contributor

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# "First node in calltree seems to be non-fuzzer function"
# )

if not profile.func_is_entrypoint(demangled_name):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one we should watch out for as I'm not sure the condition will always be true. I'm thinking with regards to Python here.

# Sort function and lines numbers for each coverage file.
# Store in function_internals.
logger.debug("Function intervals")
logger.debug("Geting function start and end line")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo

@DavidKorczynski DavidKorczynski merged commit 7602a14 into ossf:main Nov 22, 2022
@arthurscchan arthurscchan deleted the coverage-report branch November 28, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants