Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Dropbear events detection #572

Merged
merged 6 commits into from
May 8, 2015
Merged

Better Dropbear events detection #572

merged 6 commits into from
May 8, 2015

Conversation

kravietz
Copy link
Contributor

@kravietz kravietz commented Apr 7, 2015

This MR introduces improved detection of Dropbear events, which is especially useful if you're collecting logs from OpenWRT routers.

Pawel Krawczyk added 2 commits April 7, 2015 12:41
This is especially useful for detecting SSH bruteforcing events
on OpenWRT routers.
This signature will also classify these events as authentication
failuers, contributing to the password bruteforcing rule.
@ddpbsd
Copy link
Member

ddpbsd commented Apr 7, 2015

Without testing, i like the additions. Could you add a dropbear.ini in contrib/ossec-testing/tests? This is something we're trying to add as time permits, andadding it alongside new rules has been helpful.

@kravietz
Copy link
Contributor Author

kravietz commented Apr 9, 2015

Just added these, mostly mimicking what I found in sshd.ini. Let me know if it works. Also added one more detection rule for Dropbear.

@ddpbsd
Copy link
Member

ddpbsd commented Apr 9, 2015

It'll be a few days before i can test. If you don't see anything by
wednesday please ping me.
On Apr 9, 2015 5:43 AM, "Paweł Krawczyk" [email protected] wrote:

Just added these, mostly mimicking what I found in sshd.ini. Let me know
if it works. Also added one more detection rule for Dropbear.


Reply to this email directly or view it on GitHub
#572 (comment).

@ChristianBeer
Copy link
Contributor

Is it possible that the build system is wonky at the moment? I checked out this PR to my local system and ran the tests myself. The dropbear tests are passing but the pam.ini tests are failing because the pam decoder is not working. I checked that my local_decoder.xml is empty.

Edit: after cleaning my ossec directory and a fresh build both tests are passing on my local machine now. Maybe someone should rerun Travis Job 981.24

@awiddersheim
Copy link
Member

Retrying build. Lets see what happens.

@awiddersheim
Copy link
Member

Doesn't seem to have helped. Relevant lines are as follows:

https://travis-ci.org/ossec/ossec-hids/jobs/57781949#L1421-L1482

@kravietz
Copy link
Contributor Author

The dropbear_rules.xml file was not included in ossec.conf which I suppose is a sufficient reason for the rules not to work :) Just fixed in the commit above.

@ddpbsd
Copy link
Member

ddpbsd commented Apr 17, 2015

I know I asked you to add it, but can you remove the dropbear.ini file? I don't know why it's failing on travis, but it would be nice to get these additions in. The tests pass locally, but no one has been able to figure out what travis is doing to make them fail.

ddpbsd added a commit that referenced this pull request May 8, 2015
Better Dropbear events detection
@ddpbsd ddpbsd merged commit 556866b into ossec:master May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants